Bottom bar padding and optional body class#680
Merged
snide merged 1 commit intoelastic:masterfrom Apr 17, 2018
Merged
Conversation
cchaos
approved these changes
Apr 17, 2018
Contributor
cchaos
left a comment
There was a problem hiding this comment.
Works great. The only thing I noticed is that because our guide page is set to a min-height of 100vh, the body will scroll even though it doesn't need to. Not sure if we will run into this case in Kibana, but worth a look?
Contributor
Author
|
@cchaos Yeah, I noticed the same thing, that's why I added the But hopefully that should give people some flexibility with it. |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #663
EuiBottomBarwill now apply a bottom padding to the body that is the size of the bar itself. Since a user might also have fixed controls (like the docs sidenav for example), I made it so you can also attach abodyClassNameto the body when it is mounted. This should allow people to make any sort of style adjustments they need when the bar pops up.