[babel] Remove unused babel plugins/dependencies#6779
Merged
cee-chen merged 3 commits intoelastic:mainfrom May 16, 2023
Merged
Conversation
cee-chen
commented
May 16, 2023
| const keysToRemove = new Set( | ||
| toRemovePropTypes.arguments[0].elements | ||
| .map(keyToRemove => | ||
| .map((keyToRemove) => |
Contributor
Author
There was a problem hiding this comment.
whoops, sorry, I missed all these diffs when doing git add. Everything below this is all Prettier auto-save lint fixes and shouldn't materially impact functionality
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6779/ |
breehall
approved these changes
May 16, 2023
Contributor
breehall
left a comment
There was a problem hiding this comment.
No build / CI errors! Thanks for the babel cleanup!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of our ongoing
babelupgrade work (#6652). It removes the following unused babel packages:@babel/plugin-syntax-dynamic-import@babel/plugin-syntax-dynamic-importis now included automatically in@babel/coreabove v7.8.0 (which we're above) as well as in@babel/preset-envwhich we already have. As such, we shouldn't need to define it manually in our package.json or as a babel plugin.babel-plugin-dynamic-import-nodeEuiIconJest tests do not fail with this removed, which would be the primary usagebabel-core@7.0.0-bridge.0QA