Upgrade @babel/plugin-* and @babel/preset-* packages to latest#6662
Merged
cee-chen merged 5 commits intoelastic:mainfrom Mar 30, 2023
Merged
Upgrade @babel/plugin-* and @babel/preset-* packages to latest#6662cee-chen merged 5 commits intoelastic:mainfrom
@babel/plugin-* and @babel/preset-* packages to latest#6662cee-chen merged 5 commits intoelastic:mainfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6662/ |
@babel/plugin-* packages to latest@babel/plugin-* and @babel/preset-* packages to latest
Contributor
Author
|
@breehall or @daveyholler - as my M1 guinea pigs, can either of you (whoever has spare cycles soonest) QA this PR for me:
and confirm the above yarn start works successfully / does not throw errors? If no errors, please go ahead and approve this PR. Thank you! |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6662/ |
breehall
approved these changes
Mar 29, 2023
Contributor
breehall
left a comment
There was a problem hiding this comment.
This builds and starts for me with no error!
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6662/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of an ongoing effort to upgrade our various babel dependencies to the latest (#6652) in order for Storybook to work as expected.
I'm opening PRs in very very atomic increments in order to 1. get frequent help from other devs testing, so I don't run into a "it works on my machine" issue, and 2. catch any issues that may arise in CI.
QA
The following scripts work as expected locally:
yarn startyarn lintyarn test-unityarn test-cypress-devyarn test-unit accordion --coverage && yarn test-cypress && yarn combine-test-coverageyarn yo-changelogyarn build-packnpm run release(run up to the 2FA prompt and stop)yarn sync-docs