Remove node-sass in favor of dart sass#6474
Merged
cee-chen merged 6 commits intoelastic:mainfrom Dec 13, 2022
Merged
Conversation
+ update `sass-loader` while we're here
+ keep legacy `renderSync` API - not worth switching to `compile` since Sass is going away + mute `math.div` warnings - we (hopefully...) won't be on Sass long enough for 2.0.0 to come out
…or "&"` error - switch to syntax that produces the same behavior
Contributor
Author
|
@breehall and @daveyholler - as our two team members on M1/arm64, do either of you mind pulling down this branch and confirming that EUI can now be developed locally on Node v16 and without Terminal being in Rosetta mode? |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6474/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6474/ |
daveyholler
approved these changes
Dec 13, 2022
Contributor
daveyholler
left a comment
There was a problem hiding this comment.
Testing locally:
- I checked out the PR
- I removed all Node versions < 16 from my machine with
nvm uninstall <old version> - I deleted
node_modules - I
yarn installed with no errors - I
yarn started with no errors
5 tasks
breehall
approved these changes
Dec 13, 2022
Contributor
breehall
left a comment
There was a problem hiding this comment.
We're looking good! Also smoke tested in the PR preview! Thank you for you quick work on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR the last step of #6442 🎉
node-sass(which is deprecated and causing issues for M1) in favor ofsasssass'srenderAPI to their newcompileAPI - I didn't want to bother figuring that out for something we're no longer going to meaningfully support in the future&root error that cropped up as a result of the dependency changePerformance notes
Dart sass is indeed slower than node-sass (5s to 9s), but not meaningfully so for our compile times in a way which matters to us (considering we will soon be transitioning off Sass entirely).
Before:
After:
QA
node-sassandsass}spacing.euiBody--headerIsFixedand.euiBody--headerIsFixed--double.euiBody--headerIsFixedCSS class rules existGeneral checklist
N/A - dev-only