Merged
Conversation
- instead use execSync and git CLI to accomplish the same outcomes
+ remove references to nodegit
- it's no longer of use with `nodegit` removed
5 tasks
1Copenut
approved these changes
Dec 8, 2022
Contributor
1Copenut
left a comment
There was a problem hiding this comment.
👍 LGTM! I tried out the QA steps on a not-an-M1 machine and everything worked as expected.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6471/ |
- token script now relies on tags being up to date/correct, so we should fetch/prune them first
breehall
approved these changes
Dec 8, 2022
Contributor
breehall
left a comment
There was a problem hiding this comment.
🐥 Looks good! We checked this together in screen share. Can't wait to run scripts without my M1 yelling at me!
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6471/ |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of our higher-level goal of removing dependencies causing issues for M1/arm64 developers (see #6442).
Our
nodegitdependency is only used during our release script. While there are alpha versions ofnodegitthat purport to support M1, I spiked out removing/replacing the dependency totally withexecversions of git CLI commands, and was able to successful find their corresponding CLI APIs which I found easy enough to replace.While these changes may not be totally bullet or bug proof, these changes are dev-only and I feel confident enough to move forward with them as-is and fix any issues that arise during the next release.
QA
Release script
npm run releaseand confirm it outputs the following message:Unable to release: currently on branch "nodegit", expected "main"Tokens script
node scripts/update-token-changelog.js majorand confirm it outputs "No i18n token changes found to commit"i18ntokens.jsonand change the firstdefStringto (e.g.)TEST. Save (without Prettier formatting)node scripts/update-token-changelog.js majorand confirm it outputs "i18n token changes committed"git logand confirm you see anupdate i18ntokenscommitgit reset HEAD^and inspect the changed files/diff, and confirmi18ntokens_changelog.jsonlooks like this:General checklist
N/A, dev only