[Emotion] Fix/regression test more css props#6248
Merged
cee-chen merged 10 commits intoelastic:mainfrom Sep 20, 2022
Merged
Conversation
- for components/subcomponents that explicitly disallow custom `style`s + update API to take an obj of options
- converted in previous PR
+ add custom styles regression tests + DRY out repeated required component props
- requires lodash which is unfortunate, but a handy util / necessary evil that can be replaced later
css props not being correctly mergedcss props
21 tasks
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6248/ |
thompsongl
approved these changes
Sep 20, 2022
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
Does not fix/regression test all remaining components that have childProps - the changelist was getting large, and the tooltip props are slightly tricky, so I'm going to split it into (yet another) follow-up PR
Sounds good!
Comment on lines
+58
to
+62
| options: { | ||
| childProps?: string[]; | ||
| skipStyles?: boolean; | ||
| skipParentTest?: boolean; | ||
| } = {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #6239, closes #6152
This PR:
shouldRenderCustomStylesAPI to use a more future-proofoptionsobj that allows the following:stylesassertion (since some components explicitly disallow customstyles)childProps- the changelist was getting large, and the tooltip props are slightly tricky, so I'm going to split it into (yet another) follow-up PRChecklist