Skip to content

[EuiDataGrid] Fix missing cell popover shadows in Safari#6163

Merged
cee-chen merged 3 commits intoelastic:mainfrom
cee-chen:datagrid-popover-fix
Aug 23, 2022
Merged

[EuiDataGrid] Fix missing cell popover shadows in Safari#6163
cee-chen merged 3 commits intoelastic:mainfrom
cee-chen:datagrid-popover-fix

Conversation

@cee-chen
Copy link
Copy Markdown
Contributor

@cee-chen cee-chen commented Aug 23, 2022

Summary

closes #6151 - see issue for more discussion/context

Before:

After:

Checklist

  • Checked in Chrome, Safari, Edge, and Firefox
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link
Copy Markdown

Preview documentation changes for this PR: https://eui.elastic.co/pr_6163/

Copy link
Copy Markdown
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested the preview build with chrome/edge/ff/safari (on Mac). Safari looks good again, and I don't see a difference in the others

@cee-chen cee-chen enabled auto-merge (squash) August 23, 2022 22:03
@kibanamachine
Copy link
Copy Markdown

Preview documentation changes for this PR: https://eui.elastic.co/pr_6163/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DataGrid] Cell expansion missing border in Safari

3 participants