Skip to content

[Docs] Better docs for color mode#6155

Merged
elizabetdev merged 7 commits intoelastic:mainfrom
elizabetdev:EuiThemeProvider-text-and-icons-docs
Aug 24, 2022
Merged

[Docs] Better docs for color mode#6155
elizabetdev merged 7 commits intoelastic:mainfrom
elizabetdev:EuiThemeProvider-text-and-icons-docs

Conversation

@elizabetdev
Copy link
Copy Markdown
Contributor

@elizabetdev elizabetdev commented Aug 22, 2022

Summary

Closes #6123.

This PR adds better docs in https://eui.elastic.co/pr_6155/#/theming/color-mode to show how to use components like EuiText and EuiIcon in a specific color mode.

Screenshot 2022-08-23 at 10 36 35

The last example shows how to use color variables.

Screenshot 2022-08-23 at 10 36 40

@elizabetdev elizabetdev added skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) emotion labels Aug 22, 2022
@kibanamachine
Copy link
Copy Markdown

Preview documentation changes for this PR: https://eui.elastic.co/pr_6155/

@elizabetdev elizabetdev requested a review from cee-chen August 23, 2022 09:44
@elizabetdev elizabetdev marked this pull request as ready for review August 23, 2022 09:44
@kibanamachine
Copy link
Copy Markdown

Preview documentation changes for this PR: https://eui.elastic.co/pr_6155/

Copy link
Copy Markdown
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks super awesome! I have some very minor / optional copy suggestions, but honestly I think this is fine as-is as well, so feel free to merge - up to you

elizabetdev and others added 3 commits August 23, 2022 18:04
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
@kibanamachine
Copy link
Copy Markdown

Preview documentation changes for this PR: https://eui.elastic.co/pr_6155/

@elizabetdev elizabetdev merged commit 7d79e91 into elastic:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

emotion skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EuiText and EuiIcon colors should change when wrapped in EuiThemeProvider

3 participants