[EuiToolTip] Convert to Emotion styling#6104
Merged
thompsongl merged 21 commits intoelastic:mainfrom Sep 7, 2022
Merged
Conversation
49 tasks
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6104/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6104/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6104/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6104/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6104/ |
| } | ||
|
|
||
| setTootipRef: Ref<EuiToolTip> = (node) => { | ||
| setTootipRef = (node: ToolTipRef) => { |
Contributor
Author
There was a problem hiding this comment.
Yeah it's actually required for functional components, but I left it in after reverting to a class component.
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM, can't find anything misrendered or not acting correctly in the preview. Have a question about one change
chandlerprall
approved these changes
Sep 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EuiToolTipPopoverto be a function componentEuiToolTipAnchorandEuiToolTipArrowcomponentsEuiToolTipremains as a class component because of the delicate hide/show logic that the interaction relies on and because it does not actually need to useuseEuiTheme. Subcomponents were created and can handle individual styling concerns.Checklist