[BUG]: Adding role=marquee to EuiFilterButton#6076
Merged
1Copenut merged 3 commits intoelastic:mainfrom Jul 26, 2022
1Copenut:bug/badge-roll-6011
Merged
[BUG]: Adding role=marquee to EuiFilterButton#60761Copenut merged 3 commits intoelastic:mainfrom 1Copenut:bug/badge-roll-6011
role=marquee to EuiFilterButton#60761Copenut merged 3 commits intoelastic:mainfrom
1Copenut:bug/badge-roll-6011
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6076/ |
1 similar comment
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6076/ |
cee-chen
approved these changes
Jul 26, 2022
Contributor
cee-chen
left a comment
There was a problem hiding this comment.
👍 LGTM! This feels like an appropriate/clever solution.
cee-chen
reviewed
Jul 26, 2022
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6076/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@Heenawter reported an axe violation in EUI issue #6011 for the
EuiFilterButtoncomponent. I solved this issue by adding a role of "marquee" to the badge inside the button. This felt like the correct role based on MDN documentation and will be non-breaking change.Closes #6011
Checklist
Props have proper autodocs and playground togglesChecked Code Sandbox works for any docs examplesUpdated the Figma library counterpart