Skip to content

[EuiText] Fix multiple missing CSS logical properties#6059

Merged
cee-chen merged 4 commits intoelastic:mainfrom
cee-chen:emotion/text
Jul 18, 2022
Merged

[EuiText] Fix multiple missing CSS logical properties#6059
cee-chen merged 4 commits intoelastic:mainfrom
cee-chen:emotion/text

Conversation

@cee-chen
Copy link
Copy Markdown
Contributor

@cee-chen cee-chen commented Jul 18, 2022 •
edited
Loading

Summary

I missed converting a few of these properties in #5895 and #6049 🙈

Before

After

Checklist

  • Checked in direction: rtl and writing-mode: vertical-rl
  • Checked in Chrome, Safari, Edge, and Firefox
  • A changelog entry exists and is marked appropriately

@cee-chen cee-chen requested a review from elizabetdev July 18, 2022 18:49
@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Jul 18, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_6059/

elizabetdev
elizabetdev approved these changes Jul 18, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@elizabetdev elizabetdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

How did we miss that? 😄

There's also one text-align: center that can be converted to use ${logicalTextAlignCSS('center')};.

eui/src/components/text/text.styles.ts

Line 193 in e6c461f

text-align: center;

@cee-chen
Copy link
Copy Markdown
Contributor Author

cee-chen commented Jul 18, 2022

text-align: center; is the same / there isn't a logical properties equivalent, so I left that alone. No strong preference either way though, in this case I don't think it's likely to change in the future, but it's also maybe useful to include to remind us to use more logical properties in the future 🤔

thompsongl
thompsongl approved these changes Jul 18, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the snapshot update

it's also maybe useful to include to remind us to use more logical properties in the future

Yeah we have the util function so might as well use it. If it ever does change then we can update one place.

@cee-chen cee-chen enabled auto-merge (squash) July 18, 2022 20:54
@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Jul 18, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_6059/

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Jul 18, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_6059/

@cee-chen cee-chen merged commit 4ce0404 into elastic:main Jul 18, 2022
@cee-chen cee-chen deleted the emotion/text branch July 18, 2022 22:38
@cee-chen cee-chen mentioned this pull request Jul 21, 2022
Closed
@cee-chen cee-chen mentioned this pull request Aug 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@thompsongl thompsongl thompsongl approved these changes

@elizabetdev elizabetdev elizabetdev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cee-chen @kibanamachine @thompsongl @elizabetdev