Merged
Conversation
- this wasn't outputting anything meaningful as there is no `dark` key in `$titleColors`
+ convert text align to logical properties
+ respect euiCanAnimate
- move all title logic together - change ternary logic to props only instead of to entire title JSX - move `euiStat__title` to flat className, similar to `euiStat__description` - remove unnecessary string interpolation - DRY out commonProps - fix typing complaint on commonProps
Contributor
Author
|
@breehall Do you mind reviewing this when you have a quick sec? Should hopefully be pretty fast! |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5968/ |
- to use actual options instead of static & potentially stale values
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5968/ |
49 tasks
breehall
approved these changes
Jun 15, 2022
Contributor
breehall
left a comment
There was a problem hiding this comment.
The conversion looks good! Pull and tested against the current version! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts EuiStat to Emotion and also removes the CSS
--modifier classes (no usages in Kibana). The__child classes I left in-place as there were a few usages in Kibana.Things to look out for when moving styles
- [ ] Usegapproperty to add margin between items if using flex- [ ] Can any still existing.jsfiles be converted to TS?- [ ] Convert component-specific Sass vars to exported JS versions-inlineand-block(Logical properties)euiCanAnimateQA