[POC: Unmergeable] Idea on component-based theming#5888
Closed
cchaos wants to merge 6 commits intoelastic:mainfrom
Closed
[POC: Unmergeable] Idea on component-based theming#5888cchaos wants to merge 6 commits intoelastic:mainfrom
cchaos wants to merge 6 commits intoelastic:mainfrom
Conversation
added 6 commits
May 7, 2022 13:58
|
👋 Hey there. This PR hasn't had any activity for 90 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
|
❌ We're automatically closing this PR due to lack of activity. Please comment if you feel this was done in error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Theming ideas
Can prop values be generated through the global theme layer?
This is all conjecture since I don't know if the provider can be used this way.
Example: Buttons
Amsterdam theme:
Somehow the
EuiThemeProvidershould expect certain component prop type options likeThen the button component would pull the available prop's map and related styling via the provider:
This screenshots show how the docs is still looping through manual list of previously available colors, but only 3 of which are available in this theme.
The nice thing about this approach, is it will separate basic / functional styles from purely visual ones. Perhaps open up a way to make those basic / functional styles static.