[Page Template Feature] Updating EuiPageHeader to use the same paradigm as EuiPageSection#5857
Merged
cchaos merged 13 commits intoelastic:feature/page_templatesfrom May 9, 2022
Merged
Conversation
added 7 commits
April 20, 2022 11:58
same `bottomBorder`, `restrictWidth` and `paddingSize` props as EuiPageSection… (needs clenaup)
Still needs cleanup and shimmed a breakpoint mixin, not great
…ge_now/page_header
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5857/ |
added 4 commits
May 2, 2022 22:45
Contributor
Author
|
Finally..... ready for review... |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5857/ |
elizabetdev
approved these changes
May 9, 2022
Contributor
elizabetdev
left a comment
There was a problem hiding this comment.
LGTM! 🎉
Tested in Chrome, Firefox, Edge, and Safari.
added 2 commits
May 9, 2022 10:47
…page_now/page_header # Conflicts: # src/components/page/page_header/__snapshots__/page_header.test.tsx.snap # src/components/page/page_header/__snapshots__/page_header_content.test.tsx.snap # src/global_styling/mixins/_padding.ts # src/global_styling/mixins/index.ts
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5857/ |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also converted styles to Emotion.
Primarily EuiPageHeader is just a pass-through now to EuiPageHeaderContent, even just plain
children. So EuiPageHeaderContent now renders everything all of the time. EuiPageHeader acts as just a wrapper for controlling therestrictWidth,paddingSize, andbottomBorderprops just like EuiPageSection.The best docs example to test how this works in conjunction with EuiPageSection is: https://eui.elastic.co/pr_5857/#/layout/page-components#page-sections
Additions:
EuiPageHeader
extendedas an option ofbottomBorderbottomBorderin conjunction with Tabs, it's all handled programaticallyEuiPageHeaderContent
paddingSize&restrictWidthbut really only for EuiPageHeader to control thembreadcrumbsnot showing up whenalignItemswas nottopTodo in a follow up
mainuseEuiBreakpointmixin, but it needs to be fleshed out moreChecklist
[ ] Checked Code Sandbox works for any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes[ ] Updated the Figma library counterpart