Skip to content

[CSS-in-JS] Convert EuiSkipLink#5851

Merged
thompsongl merged 5 commits intoelastic:mainfrom
thompsongl:css-in-js/a11y-2
Apr 28, 2022
Merged

[CSS-in-JS] Convert EuiSkipLink#5851
thompsongl merged 5 commits intoelastic:mainfrom
thompsongl:css-in-js/a11y-2

Conversation

@thompsongl
Copy link
Copy Markdown
Contributor

@thompsongl thompsongl commented Apr 28, 2022

Summary

Converts EuiSkipLink to @emotion styling.
Enforces non-null euiTheme.levels values via typing.

Checklist

  • Checked in both light and dark modes
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Checked Code Sandbox works for any docs examples
  • Added or updated jest and cypress tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link
Copy Markdown

Preview documentation changes for this PR: https://eui.elastic.co/pr_5851/

Copy link
Copy Markdown
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with just one change needed for logical properties.

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
@kibanamachine
Copy link
Copy Markdown

Preview documentation changes for this PR: https://eui.elastic.co/pr_5851/

@thompsongl thompsongl enabled auto-merge (squash) April 28, 2022 18:54
@kibanamachine
Copy link
Copy Markdown

Preview documentation changes for this PR: https://eui.elastic.co/pr_5851/

@thompsongl thompsongl merged commit 4660508 into elastic:main Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants