[EuiAspectRatio] Remove sass and replace with inline styles#5818
Merged
snide merged 4 commits intoelastic:mainfrom Apr 20, 2022
Merged
[EuiAspectRatio] Remove sass and replace with inline styles#5818snide merged 4 commits intoelastic:mainfrom
snide merged 4 commits intoelastic:mainfrom
Conversation
49 tasks
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5818/ |
cchaos
reviewed
Apr 20, 2022
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5818/ |
cchaos
approved these changes
Apr 20, 2022
Contributor
cchaos
left a comment
There was a problem hiding this comment.
LGTM! I checked a lot of our direct uses in our docs in all three browsers. Yay for plain CSS and yay for reducing div count!
If you update from main, I think CI will pass
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5818/ |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts
EuiApsectRatioto use the newaspect-ratiocss property https://caniuse.com/mdn-css_properties_aspect-ratioThis removed a bit of the css, and since this has no themable elements, it felt best to just convert it completely to inline styles.
Checklist
[ ] Checked in both light and dark modes[ ] Props have proper autodocs and playground togglesAdded documentationChecked for accessibility including keyboard-only and screenreader modesUpdated the Figma library counterpart