[Page Templates Feature] Added EuiPageSection and updated EuiPage & EuiPageBody padding defaults#5769
Conversation
Setup pattern for demo toggles
…tes/page_docs_toggles # Conflicts: # scripts/a11y-testing.js # src-docs/src/views/page/page_template_example.js # src-docs/src/views/panel/panel_example.js
…eature_page_templates/page_docs_toggles # Conflicts: # scripts/a11y-testing.js # src-docs/src/views/page/page_template_example.js # src-docs/src/views/panel/panel_example.js
- Removed nested page header styles when within EuiPageBody (improved way of doing this coming later)
…page_now/page_docs_toggles
…ugh custom controls Update EuiPage’s example usage to use GuideSection directly
# Conflicts: # src-docs/src/views/page/page_example.js
and added EuiPageSidebar description to first example
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5769/ |
…page_now/page_section
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5769/ |
|
This feature branch PR is ready for review! |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5769/ |
elizabetdev
left a comment
There was a problem hiding this comment.
LGTM! 🎉
Tested in Chrome, Safari, Edge, and Firefox. Found some small issues but nothing that prevents it from merging.
|
@cchaos I just noticed that because we're now using the EuiPageSection in Should the EuiPageBody be by default |
|
Thanks @miukimiu ! I've addressed your comments. As for the |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5769/ |
This PR's specific commits starts at: cd2c512
The EuiPageTemplate are slightly broken at this point, don't look there yet 🙈
[Breaking] Changed default
paddingofEuiPagefrommtonone[NEW] EuiPageSection to replace EuiPageContent & EuiPageContentBody
This component handles all the
restrictWidthand border options for page sections to ensure proper extension of the border.Deprecated EuiPageContent & EuiPageContentBody
[NEW] Added
euiPaddingStylesandeuiBackgroundColorStylesglobal styling functionsI've added these new helpers in an attempt to consolidate any component's usage of padding or background colors to use a single global style option. Right now these require passing in the EuiTheme, but once #5754 merges, we'll have an easy way to create a hook version too. (That's also when we'll publicly document it).
Basic usage:
Docs
Page sectionsChecklist