[EuiButtonIcon] Add isLoading prop#5668
Merged
elizabetdev merged 8 commits intoelastic:mainfrom Mar 2, 2022
Merged
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5668/ |
1 similar comment
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5668/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5668/ |
cee-chen
approved these changes
Mar 2, 2022
Contributor
cee-chen
left a comment
There was a problem hiding this comment.
This looks great to me - I have one very minor Typescript suggestion, but that's it. I QA'd in the playground and it looked like it was working perfectly 👍
|
|
||
| // `original` size doesn't exist in `EuiLoadingSpinner` | ||
| // when the `iconSize` is `original` we don't pass any size to the `EuiLoadingSpinner` | ||
| // so it gets the default size |
Contributor
There was a problem hiding this comment.
Super appreciate this comment for context!
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5668/ |
Contributor
Author
|
Thanks @constancecchen 🎉
I fixed it. 👍🏽 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an
isLoadingprop to EuiButtonIcon and closes #5649. It follows the other buttons' patterns, when theisLoadingistruethe button gets disabled, and the icon is replaced with a EuiLoadingSpinner.The EuiButtonIcon can have different icon sizes. So the icon size also dictates the size of the EuiLoadingSpinner. For this reason and to match all the EuiButtonIcon sizes a new size was introduced to the EuiLoadingSpinner:
"XXL".There is one exception. If consumers pass
"original"toiconSizethe EuiLoadingSpinner will get its default size"m".Checklist
[ ] Checked in mobile[ ] Added documentation[ ] Checked Code Sandbox works for any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes