Merged
Conversation
Contributor
|
Totally unrelated (except peripherally to releases) - can we also add documentation on how we should be deploying https://eui.elastic.co on release? I feel like someone told me at some point but I totally forgot and it looks like the wiki doesn't mention it 🙈 |
cee-chen
reviewed
Feb 17, 2022
cee-chen
reviewed
Feb 17, 2022
cee-chen
approved these changes
Feb 17, 2022
Contributor
cee-chen
left a comment
There was a problem hiding this comment.
Thanks a million for these updates Greg! I'm at least 50% less likely to forget these steps now 🎉
One minor/non-blocking question about linking to Elastic private repos from a public repo, other than that this looks great to me
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5647/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5647/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Let's start using the
ci:deploy-cloudtag in upgrade PRs (elastic/kibana#125023 (comment))### Checklist