[EuiDataGrid] Fix console error that occurs when sorting and then hiding all columns#5635
Merged
cee-chen merged 5 commits intoelastic:mainfrom Feb 22, 2022
Merged
Conversation
11ab2ab to
de804c0
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5635/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5635/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5635/ |
Contributor
Author
|
@chandlerprall Quick re-ping on this one in case it fell off your radar! |
chandlerprall
approved these changes
Feb 22, 2022
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM; pulled & tested locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I noticed this error when randomly testing the schema example on local dev. This error appears to only occur on data grids with sorting and without trailing control columns, so https://elastic.github.io/eui/#/tabular-content/data-grid-in-memory-settings and https://elastic.github.io/eui/#/tabular-content/data-grid-schemas-and-popovers but not the main datagrid example.
It's not a serious error and doesn't affect any actual rendering, but does generate a JS/console error that is a relatively easy fix.
Repro:
Unit test check
When the newly added unit tests are run against the old code without this fix, the last test fails as expected.
Checklist