[EuiPageTemplate Feature] [Docs] Create new section for “Templates”#5625
Merged
cchaos merged 5 commits intoelastic:feature/page_templatesfrom Feb 11, 2022
Merged
Conversation
- Moves Page Template, SuperDatePicker, and Searchable Sitewide Template - Stubs in placeholder page for in lower level page components - Fixes routes
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5625/ |
elizabetdev
approved these changes
Feb 11, 2022
Contributor
elizabetdev
left a comment
There was a problem hiding this comment.
LGTM! 🎉
This new section makes total sense.
Tested in Firefox, Safari, and Chrome. Tested the links and (re)read the texts.
Just have a few suggestions.
src-docs/src/views/selectable/selectable_sitewide_template_example.js
Outdated
Show resolved
Hide resolved
thompsongl
approved these changes
Feb 11, 2022
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
LGTM with Elizabet's edits
Co-authored-by: Elizabet Oliveira <elizabet.oliveira@elastic.co>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5625/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5625/ |
This was referenced Feb 11, 2022
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first of many PR's to breakdown the work being done for EuiPageTemplate in #5454
Moves Page Template, SuperDatePicker, and Searchable Sitewide Template into a new section
Stubs in placeholder page for in lower level page components
And fixes routes associated with these new/old pages.
ChecklistNothing new was added, just shifting some docs pages and routes