[TypeScript] Return type for euiSelectableTemplateSitewideFormatOptions#5620
Merged
thompsongl merged 2 commits intoelastic:mainfrom Feb 10, 2022
Merged
[TypeScript] Return type for euiSelectableTemplateSitewideFormatOptions#5620thompsongl merged 2 commits intoelastic:mainfrom
euiSelectableTemplateSitewideFormatOptions#5620thompsongl merged 2 commits intoelastic:mainfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5620/ |
cee-chen
approved these changes
Feb 10, 2022
Contributor
cee-chen
left a comment
There was a problem hiding this comment.
I need to get better about return typing, if it can reduce inferred types/our eui.d.ts this much 🤯 Any thoughts on whether we should lint for it?
Contributor
Author
I don't know about linting, but it would be nice to have file or bundle size stats for PRs so we get notified of large increases. |
Contributor
|
I just suggested linting because it seemed like an easy way/win to resolve the issue. It looks like we could enable this now: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/explicit-function-return-type.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #5616
Adds an explicit return type of
EuiSelectableTemplateSitewideOption[]toeuiSelectableTemplateSitewideFormatOptionsto avoid a verbose inferred type resulting in hundreds of<div>and<li>DOM attributes and event handlers being added to the definition.This change will eliminate ~600 lines from
eui.d.tsChecklist