[Docs only] Remove HTML sources#5429
Merged
cee-chen merged 4 commits intoelastic:mainfrom Dec 3, 2021
Merged
Conversation
- It's unlikely we'll use this again, but I can leave it if we think we will (or we can find it in source control)
- no longer needed without renderToHtml() helper, and other test usages of html.prettyPrint were removed in elastic@50cb9e3
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5429/ |
4 tasks
elizabetdev
approved these changes
Dec 3, 2021
Contributor
elizabetdev
left a comment
There was a problem hiding this comment.
Thanks, @constancecchen! LGTM! 🎉
I basically looked at the code and your magic of VSCode regex find & replace seems to work well!
Goodbye HTML sources! 👋🏽
Contributor
Author
|
Thanks Elizabet!! @chandlerprall or @thompsongl do either of y'all want to look at this real quick to confirm that we likely won't need the |
Contributor
Confirmed, this is fantastic! |
thompsongl
approved these changes
Dec 3, 2021
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I recently saw #5401 and Caroline removing
GuideSectionTypes.HTMLfrom a PR, and thought I'd help us by removing all of these at once from the codebase thanks to the magic of VSCode regex find & replace.Checklist
N/A, internal change / tech debt cleanup. In theory nothing should change on the production docs site since we were already skipping/not rendering HTML tabs.