[Cypress] Add EUI's styles to test environment#5371
[Cypress] Add EUI's styles to test environment#5371chandlerprall merged 4 commits intoelastic:mainfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5371/ |
|
At a glance (although admittedly I haven't looked deeply) this approach looks solid and scripts/cypress.js LGTM! 👍 I don't see any issues with this overall approach - were there any you were anticipating? |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5371/ |
|
Pushed up final changes to the
Nope! Just didn't want to go down a rabbit hole with the script + cypress flags if there'd be pushback on the approach :) |
cee-chen
left a comment
There was a problem hiding this comment.
Working perfectly for me! 🎉
I have just one super minor comment about the theme being used, but it's absolutely not a blocker and we can move this PR forward without it or circle back to it later
| if (!skipScss) { | ||
| console.log(info('Compiling SCSS')); | ||
| execSync( | ||
| `TARGET_THEME=amsterdam_dark yarn compile-scss`, |
There was a problem hiding this comment.
Any thoughts on allowing us to specify which theme the dev wants to use as an arg? e.g. yarn test-cypress-dev --theme=dark/light or similar? I'll honestly admit I'm a garbage human being and not a huge fan of dark modes.
No worries either way, this might actually help me test more in dark modes and it's definitely not a blocker!
There was a problem hiding this comment.
I'll honestly admit I'm a garbage human being and not a huge fan of dark modes.
Me too! Good to know there's 2 of us 😆 (and caught up with Greg's comment, a whole 3 of us!), this was the first time I ever reached for dark mode as a default. I like your idea of choosing a theme.
thompsongl
left a comment
There was a problem hiding this comment.
I'm a garbage human being and not a huge fan of dark modes
That makes two of us 🙃
I'd say merge as-is and consider theme switching later if it seems useful
|
I like the theme switch suggestion, as well as the one to merge this as-is. I'll create a follow-up PR with theme selection. |
Summary
Opening as draft because the Cypress arguments section in cypress-testing.md is now broken.
Imports the compiled CSS theme file into Cypress's test environment for more accurate tests.
--skip-cssflag to allow avoiding CSS compilation time--devflag to open the Cypress dev environmentChecklist