[i18n] Support user defined component#5337
Merged
thompsongl merged 9 commits intoelastic:masterfrom Nov 1, 2021
Merged
Conversation
10 tasks
Contributor
Author
|
FWIW I was going to approve the original PR after I added 489d981 |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5337/ |
cee-chen
approved these changes
Oct 29, 2021
Contributor
cee-chen
left a comment
There was a problem hiding this comment.
QA and basic functionality LGTM! I have some minor comments around the documentation/demo, but they're not blocking
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5337/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces #5236, which got into a bad git state (cc @ym)
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked for accessibility including keyboard-only and screenreader modes