[EuiSuperDatePicker] Fix multiple IDs regenerating on rerender#5200
Merged
cee-chen merged 3 commits intoelastic:masterfrom Sep 21, 2021
Merged
Conversation
- storing all generated IDs as class vars prevents change on rerender
cee-chen
commented
Sep 20, 2021
| }; | ||
|
|
||
| generateId = htmlIdGenerator(); | ||
| relativeDateInputNumberDescriptionId = htmlIdGenerator()(); |
| commonlyUsedRanges, | ||
| }) => { | ||
| const legendId = generateId(); | ||
| const legendId = useGeneratedHtmlId(); |
| recentlyUsedRanges = [], | ||
| }) => { | ||
| const legendId = generateId(); | ||
| const legendId = useGeneratedHtmlId(); |
Comment on lines
+80
to
+81
| timeSelectionId = this.generateId(); | ||
| legendId = this.generateId(); |
Comment on lines
+93
to
+94
| legendId = this.generateId(); | ||
| refreshSelectionId = this.generateId(); |
1 task
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5200/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parent PR:
Checklist
QA screencaps below in code comments.
Changelog will be added in a single entry in #5195.