[Amsterdam] Fixed EuiButtonGroup's border-radius and font-weight, and Fixed EuiButton's text color for text colors#5177
Merged
cchaos merged 7 commits intoelastic:masterfrom Sep 20, 2021
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5177/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5177/ |
Contributor
Author
|
@miukimiu Can I get your review on this one since it's mostly styling? |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5177/ |
elizabetdev
approved these changes
Sep 20, 2021
Contributor
elizabetdev
left a comment
There was a problem hiding this comment.
LGTM! 🎉
Tested in Chrome, Safari, Edge and, Firefox. I also looked at the code. 👍🏽
Co-authored-by: Elizabet Oliveira <elizabet.oliveira@elastic.co>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5177/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[EuiButtonGroup] Fixed border-radius and font-weight for Amsterdam theme
The
smallgroup wasn't getting the right border-radius size because of inheritance. And the font-weight wasn't increased when we did so for the other buttons.Before (button vs button group)
After
[EuiButton] Fixed text color for text colored buttons to have more contrast using
$euiTextColorFollowing the pattern that was actually already set in EuiButtonGroup to make the text more visible in text colored buttons (EuiButton and EuiIconButton), I swapped those to manually get the
$euiTextColor. This also helps to further differentiate it from disabled buttons. 🤞Before
After
Checklist
- [ ] Checked in mobile- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for any docs examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes