EuiWrappingPopover example in popover docs for help#5102
Closed
rshen91 wants to merge 1 commit intoelastic:masterfrom
Closed
EuiWrappingPopover example in popover docs for help#5102rshen91 wants to merge 1 commit intoelastic:masterfrom
rshen91 wants to merge 1 commit intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5102/ |
Contributor
|
@rshen91 I don't have a good answer yet as to why focus isn't returned automatically, but introducing a slight timeout to const handleClose = () => {
onClose();
- anchor.focus()
+ requestAnimationFrame(() => anchor.focus());
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is for further context in issue #5015
The example is in http://localhost:8030/#/layout/popover at the bottom elastic_charts_wrapping_example.js is the file. The demo is
<ElasticChartsColorPickerStoryExample />User should be able to use the tab key to select the color icon and then hit the enter key to open the color picker. They can then tab through all the options in the color picker. The issue Im having and am stuck on is when the user hits Enter on the Done button, focus is not returned to the legend item color icon. The behavior is fine with the escape key when the color picker is open.
Thank you!
Checklist