Remove EuiKeyboardAccessible#4991
Conversation
76eacf7 to
c3a5a36
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4991/ |
|
|
||
| // TODO remove - this implementation is not actually accessible | ||
| // https://github.com/elastic/eui/issues/4155 | ||
| export class EuiKeyboardAccessible extends Component<Props> { |
There was a problem hiding this comment.
Can we at least re-name to be table specific? So that when we "get rid of it", it might actually just be implementing a better solution to making the rows clickable.
There was a problem hiding this comment.
So... I ended up removing it afterall and reimplementing the same solution inline in EuiTableRow (but with only the bits it needs).
Assuming this merges, I'll update #4155 with the latest details.
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4991/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4991/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4991/ |
cchaos
left a comment
There was a problem hiding this comment.
🙇 Thank you for moving that into the table row.
I checked that the rows were at least still focusable but I couldn't find any existing examples that do anything with the event. So LGTM 🤷 😆
Summary
EuiKeyboardAccessible has been deprecated since Oct 2020 and all instances have been removed from Kibana. Removed it from EUI though rewrote a small version of it to fill in the gap left in EuiBasicTable which uses it for clickable rows. (That's it's own a11y issue but a difficult and more involved fix so not going to tackle it all at once. #4155)
Checklist
Check against all themes for compatibility in both light and dark modesChecked in mobileChecked in Chrome, Safari, Edge, and FirefoxProps have proper autodocs and playground togglesChecked Code Sandbox works for the any docs examplesChecked for accessibility including keyboard-only and screenreader modes