[EuiTourStep] title and subtitle should accept ReactNode#4841
Merged
elizabetdev merged 3 commits intoelastic:masterfrom May 31, 2021
Merged
[EuiTourStep] title and subtitle should accept ReactNode#4841elizabetdev merged 3 commits intoelastic:masterfrom
elizabetdev merged 3 commits intoelastic:masterfrom
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
Contributor
|
Hi @RhnSharma 👋🏽 , Could you please sign the Contributor Agreement so we can review your PR? |
Contributor
Author
|
@miukimiu I signed the contributor agreement. |
Contributor
|
jenkin test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4841/ |
elizabetdev
approved these changes
May 31, 2021
Contributor
elizabetdev
left a comment
There was a problem hiding this comment.
Thanks @RhnSharma,
I tested in Chrome, Firefox, Safari, Edge, and LGTM! 🎉
I also added a changelog entry and improved the props descriptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4840.
Updated
EuiTourStep'stitleandsubtitleprop type fromstringtoReactNodeChecklist
[ ] Checked in mobile[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes ([EuiLoading] Accessibility props #4814 has ideas to address a11y, should be a follow-up)