Skip to content

[EuiFormRow] Changed the helpText prop to accept an array of messages#4782

Merged
elizabetdev merged 3 commits intoelastic:masterfrom
hetanthakkar:EuiFormRow
May 13, 2021
Merged

[EuiFormRow] Changed the helpText prop to accept an array of messages#4782
elizabetdev merged 3 commits intoelastic:masterfrom
hetanthakkar:EuiFormRow

Conversation

@hetanthakkar
Copy link
Copy Markdown
Contributor

@hetanthakkar hetanthakkar commented May 5, 2021 •
edited by elizabetdev
Loading

Summary

Fixes #4775

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented May 5, 2021

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@hetanthakkar
Copy link
Copy Markdown
Contributor Author

hetanthakkar commented May 5, 2021

@cchaos I am a bit skeptical about my approach and the modifications I made in test

@cchaos
Copy link
Copy Markdown
Contributor

cchaos commented May 5, 2021

Thanks @hetanthakkar1. Can you please add some screenshots of this working?

@hetanthakkar
Copy link
Copy Markdown
Contributor Author

hetanthakkar commented May 5, 2021 •
edited
Loading

@cchaos This is how it looks
image

@elizabetdev elizabetdev changed the title Changed the helpText prope in EuiFormRow to accept an array of messages Changed the helpText prop in EuiFormRow to accept an array of messages May 6, 2021
@cchaos
Copy link
Copy Markdown
Contributor

cchaos commented May 6, 2021

Jenkins, test this

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented May 6, 2021

Preview documentation changes for this PR: https://eui.elastic.co/pr_4782/

@thompsongl thompsongl self-requested a review May 6, 2021 14:13
@hetanthakkar
Copy link
Copy Markdown
Contributor Author

hetanthakkar commented May 6, 2021

@thompsongl anything more that can be done!? or needs to be changed

@elizabetdev elizabetdev self-requested a review May 12, 2021 12:54
@elizabetdev
Copy link
Copy Markdown
Contributor

elizabetdev commented May 13, 2021

jenkins test this

@elizabetdev elizabetdev changed the title Changed the helpText prop in EuiFormRow to accept an array of messages [EuiFormRow] Changed the helpText prop to accept an array of messages May 13, 2021
@kibanamachine
Copy link
Copy Markdown

kibanamachine commented May 13, 2021

Preview documentation changes for this PR: https://eui.elastic.co/pr_4782/

elizabetdev
elizabetdev approved these changes May 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@elizabetdev elizabetdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hetanthakkar1,
Tested locally and on different browsers. LGTM! 🎉

thompsongl
thompsongl approved these changes May 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM!

@elizabetdev elizabetdev merged commit 0b660a5 into elastic:master May 13, 2021
@hetanthakkar
Copy link
Copy Markdown
Contributor Author

hetanthakkar commented May 13, 2021

thank you elastic team @miukimiu @thompsongl and everyone for the review!

@thompsongl thompsongl mentioned this pull request Jun 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@thompsongl thompsongl thompsongl approved these changes

@elizabetdev elizabetdev elizabetdev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[EuiFormRow] Allow helpText to take in an array of messages just like error does

5 participants

@hetanthakkar @kibanamachine @cchaos @elizabetdev @thompsongl