Icon Additions for Upcoming Lens Features#4779
Icon Additions for Upcoming Lens Features#4779MichaelMarcialis merged 7 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4779/ |
There was a problem hiding this comment.
Thanks @MichaelMarcialis,
These icons look amazing. 🎉
I look at the code and it looks good. Also tested in light and dark mode, and in Figma using the grid to see the alignments.
One thing that I noticed looking at the documentation and doing my Figma tests is that the eraser icon seems more left-aligned than centered:
I think it seems more centered if we move the icon 1px to the right. What do you think?
Good catch! I'll update shortly. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4779/ |
elizabetdev
left a comment
There was a problem hiding this comment.
Thanks, @MichaelMarcialis for making the changes!
LGTM! 🎉
Summary
Added some new icons to EUI to support the needs of upcoming Lens features (dynamic coloring, thresholds, custom formula). This PR includes the following icons:
color(was already in Figma; just added to EUI repo)continuityAbovecontinuityAboveBelowcontinuityBelowcontinuityWithineraserfullScreenExitfunction(was already in Figma; just added to EUI repo)percent(for use in icon-only elements, such asEuiButtonIconand icon-onlyEuiButtonGroupcomponents)wordWrapwordWrapDisabledChecklist
[ ] Checked in mobile[ ] Props have proper autodocs and playground toggles[ ] Checked Code Sandbox works for the any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes