[EuiColorStops] Ensure popover close on outside click#4687
Merged
thompsongl merged 4 commits intoelastic:masterfrom Apr 6, 2021
Merged
[EuiColorStops] Ensure popover close on outside click#4687thompsongl merged 4 commits intoelastic:masterfrom
thompsongl merged 4 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4687/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4679. Changes to
ownFocusinEuiPopoveraffected the underlying focus trap on outside clicks. Clicking a color stop thumb while the popover was open would disable the underlying focus trap, causing the focus trap to no longer watch for outside clicks. We don't want the EuiColorStopThumb popover trap to be disabled on outside click; instead, we the trap should remain active while the popover is open.I decided to expand the prop options beyond what we currently need. Can be expanded further in the future if necessary.
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Added documentation