Skip to content

Fixed htmlIdGenerator import#4682

Merged
cchaos merged 3 commits intoelastic:masterfrom
gebeto:patch-1
Apr 2, 2021
Merged

Fixed htmlIdGenerator import#4682
cchaos merged 3 commits intoelastic:masterfrom
gebeto:patch-1

Conversation

@gebeto
Copy link
Copy Markdown
Contributor

@gebeto gebeto commented Apr 1, 2021

Fixed htmlIdGenerator import

Summary

Fixed bad imported htmlIdGenerator that throwing an error on build my(and any other) project

Screenshot 2021-04-01 at 22 45 11

@cla-checker-service
Copy link
Copy Markdown

cla-checker-service bot commented Apr 1, 2021

💚 CLA has been signed

@gebeto gebeto closed this Apr 2, 2021
@gebeto gebeto reopened this Apr 2, 2021
@kibanamachine
Copy link
Copy Markdown

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cchaos
Copy link
Copy Markdown
Contributor

cchaos commented Apr 2, 2021

Jenkins, test this

@cchaos
Copy link
Copy Markdown
Contributor

cchaos commented Apr 2, 2021

👋 Welcome @gebeto ! I got CI (Jenkins) started for you which will run our tests and get a preview built.

Quick note, because this is a docs-only change, it actually does not need a changelog. Our Github bot doesn't know this, so sorry for that confusion. I'll add the appropriate labels.

@cchaos cchaos added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) labels Apr 2, 2021
@cchaos
Copy link
Copy Markdown
Contributor

cchaos commented Apr 2, 2021

Oh nevermind, I was mistaken, this IS in the component itself. 👀

@cchaos cchaos removed documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) labels Apr 2, 2021
Fixed htmlIdGenerator import
@kibanamachine
Copy link
Copy Markdown

Preview documentation changes for this PR: https://eui.elastic.co/pr_4682/

@gebeto
Copy link
Copy Markdown
Contributor Author

gebeto commented Apr 2, 2021

Thanks @cchaos ! There was one mistake made by me in CHANGELOG.md so I've fixed it and pushed new changes. Can you please run CI again?

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
@cchaos
Copy link
Copy Markdown
Contributor

cchaos commented Apr 2, 2021

Jenkins, test this

Copy link
Copy Markdown
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this fix! 🎉 Surprised our CI build didn't catch it in the first place. I'll merge when CI is green.

With one last CL fix 🤦

@kibanamachine
Copy link
Copy Markdown

Preview documentation changes for this PR: https://eui.elastic.co/pr_4682/

@chandlerprall
Copy link
Copy Markdown
Contributor

chandlerprall commented Apr 2, 2021

System error running the accessibility tests, retrying: jenkins test this

@cchaos
Copy link
Copy Markdown
Contributor

cchaos commented Apr 2, 2021

Decided to merge that CL change real quick before Jenkins go too far in.

Jenkins, test this

@kibanamachine
Copy link
Copy Markdown

Preview documentation changes for this PR: https://eui.elastic.co/pr_4682/

@chandlerprall
Copy link
Copy Markdown
Contributor

Known flaky test that time 🤦: jenkins test this

@kibanamachine
Copy link
Copy Markdown

Preview documentation changes for this PR: https://eui.elastic.co/pr_4682/

@cchaos cchaos merged commit 0b0e294 into elastic:master Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants