[Docs] Updates Accordion, Bottom bar, Flex, and Flyout pages#4655
Merged
cchaos merged 8 commits intoelastic:masterfrom Mar 25, 2021
Merged
[Docs] Updates Accordion, Bottom bar, Flex, and Flyout pages#4655cchaos merged 8 commits intoelastic:masterfrom
cchaos merged 8 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4655/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4655/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4655/ |
snide
approved these changes
Mar 23, 2021
Contributor
snide
left a comment
There was a problem hiding this comment.
Small bits I noticed. Nice work.
Co-authored-by: Dave Snider <dave.snider@gmail.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4655/ |
Contributor
Author
|
I need to merge this because I have some updates to do for Flyout. Gonna merge upstream and run CI, then merge. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4655/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting a series of PR's to fix up docs pages to make better use of the new docs layout and increase clarity
This one tackles Accordion, Bottom bar, Flex, and Flyout pages
Fixes #4139 by adding this section: https://eui.elastic.co/pr_4655/#/layout/flex#flex-items-are-also-flex
Checklist
[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes[ ] A changelog entry exists and is marked appropriately