Skip to content

[Docs] Added the ability to navigate through the docs pages using keyboard arrows#4600

Merged
thompsongl merged 5 commits intoelastic:masterfrom
akashgp09:handle-routes
Mar 4, 2021
Merged

[Docs] Added the ability to navigate through the docs pages using keyboard arrows#4600
thompsongl merged 5 commits intoelastic:masterfrom
akashgp09:handle-routes

Conversation

@akashgp09
Copy link
Copy Markdown
Contributor

@akashgp09 akashgp09 commented Mar 3, 2021

Summary

This PR Fixes: #4585

Added the ability to navigate through the docs pages using the left/right keyboard arrows.
Discussion

ezgif-2-fa3f196f6ee3

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Edge, and Firefox
    - [ ] Props have proper autodocs and playground toggles
    - [ ] Added documentation
    - [ ] Checked Code Sandbox works for the any docs examples
    - [ ] Added or updated jest tests
    - [ ] Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link
Copy Markdown

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@thompsongl
Copy link
Copy Markdown
Contributor

jenkins test this

@kibanamachine
Copy link
Copy Markdown

Preview documentation changes for this PR: https://eui.elastic.co/pr_4600/

Copy link
Copy Markdown
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 This little hidden navigation feature has helped me so much in development. I really missed it. I'll leave it to an eng to check the history stuff.

Btw, because this is a documentation only fix, we actually don't need a changelog entry.

@cchaos cchaos added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) labels Mar 3, 2021
@thompsongl thompsongl self-requested a review March 4, 2021 16:47
Copy link
Copy Markdown
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thompsongl
Copy link
Copy Markdown
Contributor

jenkins test this

@kibanamachine
Copy link
Copy Markdown

Preview documentation changes for this PR: https://eui.elastic.co/pr_4600/

@thompsongl
Copy link
Copy Markdown
Contributor

jenkins test this

@kibanamachine
Copy link
Copy Markdown

Preview documentation changes for this PR: https://eui.elastic.co/pr_4600/

@thompsongl thompsongl merged commit 1b5b920 into elastic:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs] Add back in the ability to page through the docs pages using the left/right keyboard arrows

4 participants