You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes#4595 by removing EuiPageSideBarProps and EuiPageTemplateProps exports from src/components/index.js as they are TypeScript definitions and removed from the transpiled code.
I confirmed with BABEL_MODULES=false yarn webpack --config=src/webpack.config.js that these are the only two such exports.
Thanks @orhantoy ; I'll remove it as well, and am looking into why webpack warned/failed on the other 2 exported types but not EuiSideNavProps. Is this one causing a build failure for you?
@chandlerprall No build failure, just mentioning it here because I also ran into the issue with EuiPageSideBarProps, and while investigating I noticed EuiSideNavProps.
why webpack warned/failed on the other 2 exported types but not EuiSideNavProps
side_nav/index.ts exports * from whereas page/index.ts has explicit exports, looks like webpack only inspects one layer deep when issuing that warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4595 by removing
EuiPageSideBarPropsandEuiPageTemplatePropsexports from src/components/index.js as they are TypeScript definitions and removed from the transpiled code.I confirmed with
BABEL_MODULES=false yarn webpack --config=src/webpack.config.jsthat these are the only two such exports.