Skip to content

Prevent the changelog check from running on commits to master#4592

Merged
chandlerprall merged 1 commit intomasterfrom
bug-dont-revalidate-changelog-on-merge
Mar 2, 2021
Merged

Prevent the changelog check from running on commits to master#4592
chandlerprall merged 1 commit intomasterfrom
bug-dont-revalidate-changelog-on-merge

Conversation

@chandlerprall
Copy link
Copy Markdown
Contributor

Summary

I believe this will prevent the warning emails when merging PRs into master

@chandlerprall chandlerprall added the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label Mar 2, 2021
@chandlerprall chandlerprall requested review from cchaos and snide March 2, 2021 18:08
Copy link
Copy Markdown
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's try it!

Also as an FYI, you can at least mute these workflow emails in your Github settings.

Copy link
Copy Markdown
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No way to see until we merge. I'd double check that commits ADDING the changelog rerun the check in PRs that don't have one. I don't think I was able to see that happen without the push type. I wonder if pull_request has an updated type for new commits.

@kibanamachine
Copy link
Copy Markdown

Preview documentation changes for this PR: https://eui.elastic.co/pr_4592/

@chandlerprall chandlerprall merged commit 8ec5f72 into master Mar 2, 2021
@chandlerprall chandlerprall deleted the bug-dont-revalidate-changelog-on-merge branch March 2, 2021 20:22
@chandlerprall
Copy link
Copy Markdown
Contributor Author

Well this didn't help 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants