[Docs] Removed all isNew declarations on components over 6 months old#4591
Merged
cchaos merged 1 commit intoelastic:masterfrom Mar 2, 2021
Merged
[Docs] Removed all isNew declarations on components over 6 months old#4591cchaos merged 1 commit intoelastic:masterfrom
isNew declarations on components over 6 months old#4591cchaos merged 1 commit intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4591/ |
thompsongl
approved these changes
Mar 2, 2021
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
Are there any components we missed putting the isNew badge on?
EuiColorPaletteDisplay is the only one I can think of, but it's not possible to put a badge on it.
elizabetdev
approved these changes
Mar 2, 2021
Contributor
elizabetdev
left a comment
There was a problem hiding this comment.
LGTM! 🎉
Tested in Chrome, Safari, Edge, and Firefox. I confirm that all the badges are gone! 🥳
chandlerprall
approved these changes
Mar 2, 2021
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
All of these removals 👍 Looked through the git history for src-docs/views and didn't notice any new components missing the isNew flag.
Contributor
Author
|
Thanks all! I also wanted to be sure you all were good with these removals. Hopefully we'll have more "NEW" soon 😜 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've kept some of these NEW badges on a little too long so I've cleaned up the usages to remove them from any that were applied more than 6 months ago. This pretty much wiped out all the badges since the youngest one was 7 months old.
Are there any components we missed putting the
isNewbadge on?There's been talk about creating some automatic timer for these, but I didn't feel like going down that rabbit hole at the moment. I just wanted to clean up the usages before the next release that will contain the docs layout redesign.
Checklist