[EuiDataGrid] Update jest environment rendering to include all cells#4589
Merged
chandlerprall merged 1 commit intoelastic:masterfrom Mar 2, 2021
Merged
Conversation
Contributor
|
jenkins test this
|
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4589/ |
thompsongl
approved these changes
Mar 1, 2021
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
Looks "SAFE" to me
Just curious if you can think of any potential downsides to the large dimensions; I couldn't think of anything immediate.
Contributor
Author
Only thing that I've been able to come up with is if someone's adding the _isJest flag in another environment such as cypress. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4514. Instead of falling back to 500x500 height/width when rendering the datagrid within Jest, now using
Number.MAX_SAFE_INTEGER. Tried first withInfinitybut the values are passed in astyleobject which doesn't supportInfinity.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Checked for accessibility including keyboard-only and screenreader modes- [ ] A changelog entry exists and is marked appropriately