Increase start-server-and-test timeout to address CI timeouts#4580
Merged
chandlerprall merged 1 commit intoelastic:masterfrom Feb 26, 2021
Merged
Increase start-server-and-test timeout to address CI timeouts#4580chandlerprall merged 1 commit intoelastic:masterfrom
chandlerprall merged 1 commit intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4580/ |
thompsongl
approved these changes
Feb 25, 2021
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
This is a bandaid to help CI executions, I'm sure we can find ways to decrease build times rather than accepting the current times.
Agreed, but this will be helpful for now. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Increases
start-server-and-test's timeout from 5 minutes (default) to 10 minutes. This is a bandaid to help CI executions, I'm sure we can find ways to decrease build times rather than accepting the current times.How I got here:
First thought the timeout was coming from puppeteer, and tried recreating the error by decreasing pupeeter's timeout but got a different error. Looking at the CI stacktrace closer, it appeared to be from
start-server-and-testitself. Pulled up that docs, saw the default timeout of 5 minutes matches the time passed in CI between command & error, and successfully triggered that error locally with a timeout of 10ms.