Merged
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4501/ |
chandlerprall
approved these changes
Feb 9, 2021
Contributor
Author
|
Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4501/ |
elizabetdev
approved these changes
Feb 10, 2021
Contributor
elizabetdev
left a comment
There was a problem hiding this comment.
LGTM! 🎉
Tested in Chrome, Safari, Edge, and Firefox. Also tested the playground.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4501/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly affects the Amsterdam theme
This PR is to align the styles of EuiTabs with the latest from the Amsterdam design assets. The main problem we had was that the smaller (
14px) font size affected both the medium and small sizes of tabs. This is actually good for maintaining font size consistency, but we had needs for a larger set as well. One that bumped the font size back up to16px.What the results are is that:
s14px14pxm16px14pxl16px16pxThis might seem weird on the surface that only
medium(default) tab font sizes are different across themes, but this is intentional. And this affects both the default andcondenseddisplays.Default theme
Amsterdam theme
Checklist
[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes