[EuiInMemoryTable] Remove spacer after childrenBetween#4248
Merged
cchaos merged 4 commits intoelastic:masterfrom Nov 10, 2020
Merged
[EuiInMemoryTable] Remove spacer after childrenBetween#4248cchaos merged 4 commits intoelastic:masterfrom
childrenBetween#4248cchaos merged 4 commits intoelastic:masterfrom
Conversation
Contributor
Author
|
cc @pgayvallet |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4248/ |
thompsongl
approved these changes
Nov 10, 2020
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
Makes sense and looks good!
+1 to the external state example updates, also
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4246
When
childrenBetweenwas added, it also added a conditional spacer between it and the search bar (keeping the spacer that existed before the table). The main consumer for needing tehchildrenBetweendoesn't want this spacer/wants to manually handle this spacing that exists between the children and the table.This PR, moves the pre-existing spacer to only display if the search bar exists and after the search bar (before the children). So if consumers addd any
childrenBetweenthey will need to add their own spacer between it and the table.The only possible implications with this change is that it does now make the pre-existing spacer conditional upon the presence of the search bar. So if consumers were using the EuiInMemoryTable without search, it did have a large spacer between the content that came before it which they may have accounted for. But now that space is gone.
I also updated one of the examples to use Facets instead of checkable cards as the more appropriate component.
Checklist
[ ] Check against all themes for compatibility in both light and dark modes[ ] Checked in Chrome, Safari, Edge, and Firefox[ ] Props have proper autodocs[ ] Checked Code Sandbox works for the any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes