[Docs, EuiInMemoryTable] Recreating props tables#4179
[Docs, EuiInMemoryTable] Recreating props tables#4179elizabetdev merged 7 commits intoelastic:masterfrom
Conversation
|
@thompsongl, when I comment on
The props table notes column shows empty:
|
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4179/ |
thompsongl
left a comment
There was a problem hiding this comment.
The props table notes column shows empty
It appears to be working, both the in docs build preview and locally:
I suspect that the dev server cache loader is to blame in your case; try deleting .cache-loader
…replace-props-table
|
Thanks, @thompsongl. Deleting the cache worked. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4179/ |
thompsongl
left a comment
There was a problem hiding this comment.
Need to merge master and move the changelog entry, but otherwise LGTM
Noted the follow-up PRs mentioned in the summary
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4179/ |
Summary
Closes #4149
The EuiInMemoryTable was using a
props_info.jsfile to generate the props table in our docs. With this PR I'm using the new!!prop-loader!to recreate the EuiInMemoryTable props tables.I'm also deleting the
props_info.jsfrom the EuiBasicTable that was also being used to generate the EuiInMemoryTable props tables.This PR also closes #3623. Now both EuiBasicTable and EuiInMemoryTable props tables are showing common props like
data-test-subjandclassName.We're still having some issues with
export type ...which shows empty. For this reason, #3381 will be addressed with #4129.Checklist
[ ] Checked in mobile[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes