[EuiComboBox] Fix issue with duplicate checkmarks#4162
Merged
timroes merged 5 commits intoelastic:masterfrom Oct 20, 2020
Merged
[EuiComboBox] Fix issue with duplicate checkmarks#4162timroes merged 5 commits intoelastic:masterfrom
timroes merged 5 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4162/ |
1 task
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4162/ |
chandlerprall
approved these changes
Oct 20, 2020
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM, pulled & tested locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an issue that items inside a combo box with the same label (but different keys) will both look checked once one of them is marked:
Checklist