EuiBottomBar: allow customization of whether the component makes room for itself#4156
Merged
cchaos merged 13 commits intoelastic:masterfrom Oct 27, 2020
Merged
Conversation
* Add new `affordForDisplacement` prop (default: true) to allow customization of whether the component makes room for itself by adding padding equivalent to its own height on the document body element. Use case a web app which ordinarily doesn't require vertical scrollbars (with a large enough browser viewport) - the existing unconfigurable behavior was forcing a vertical scrollbar to appear in this scenario, as can be seen in the updated component doc page. * Make clear that the `paddingSize` prop default is "m".
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
…arAffordForDisplacement
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4156/ |
chandlerprall
suggested changes
Oct 22, 2020
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Overall approach LGTM; some requests around implementation and/or documentation
…isplacement-changes Apply PR requests to EuiBottomBar
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4156/ |
chandlerprall
approved these changes
Oct 27, 2020
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
LGTM! Pulled & tested locally
added 2 commits
October 27, 2020 11:05
…arAffordForDisplacement
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4156/ |
Contributor
|
@cchaos I appreciate you taking the time to get this over the line in my absence! (@chandlerprall too!) Thank you both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #3641 from @dannya
Checklist
[ ] Checked Code Sandbox works for the any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes