Conversation
|
|
||
| import { htmlIdGenerator } from '../../../services'; | ||
|
|
||
| export const useCombinedRefs = <T extends any>( |
There was a problem hiding this comment.
@thompsongl This seems to work, but I don't know if it's very elegant? If we keep it I guess it could be a small service? The refs check has a TS error that I didn't know how to resolve.
|
cc @spong. Haven't forgotten about this one. I'm hopeful I can get this implemented into Kibana sometime next week. |
|
An update. I took some of this code into Kibana and was able to pretty easily replicate the functionality with the current KQL bar. This EUI version is more complicated (because it has to consider the textarea in so many different scenarios). End result, I'm probably going to put up a PR on the Kibana side to cover the functionality we want for 7.9 that isn't dependent on this work. This EUI version can lag, and might be questionable (it adds a lot of magical complexity) as a default part of the component. Will chat with @thompsongl and @cchaos about that portion next week. |
|
Some clean up work in snide#12 that we can look at next week |
[WIP] EuiTextArea
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3664/ |
|
Just a note since I'll be out for a couple weeks. We're gonna keep this PR in EUI, because it's useful for other components (like the markdown editor). I'll get it cleaned up when I get back. In the meantime, the Kibana PR is moving along and will ship with 7.9. It work on similar, but simpler logic. |
|
I'm closing this one out. We covered this on the Kibana side and I haven't seen much need to add something this prone to misuse in EUI directly. We can always revisit later if we need it. |
Summary
Makes textareas similar to our other
EuiFieldbased inputs, wrapping them inEuiFormControlLayout. Textareas now have the ability to have loading, readonly, prepend and append states. Additionally there are new props forautoHeightandmaxHeightthat when used, give the ability for textareas to autosize to the content when you start writing in them.TODO
EuiSuggestto make use of the new textareaChecklist