Skip to content

[EuiSelectable] Adding more keyboard shortcuts and screen reader instructions#3620

Merged
myasonik merged 2 commits intoelastic:feature/selectable-a11yfrom
myasonik:selectable-a11y/exclusion
Jun 18, 2020
Merged

[EuiSelectable] Adding more keyboard shortcuts and screen reader instructions#3620
myasonik merged 2 commits intoelastic:feature/selectable-a11yfrom
myasonik:selectable-a11y/exclusion

Conversation

@myasonik
Copy link
Copy Markdown
Contributor

@myasonik myasonik commented Jun 16, 2020 •
edited
Loading

Summary

  1. Adds a couple more keyboard shortcuts
    • Home to go to top of the list
    • End to go to the end of the list
    • Space as an alias for Enter
  2. Adds some instructions to the exclusion states

Checklist

  • Updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes

@myasonik myasonik changed the title adding more keyboard shortcuts and instructions [EuiSelectable] Adding more keyboard shortcuts and screen reader instructions Jun 16, 2020
@chandlerprall
Copy link
Copy Markdown
Contributor

chandlerprall commented Jun 18, 2020

jenkins test this

@chandlerprall
Copy link
Copy Markdown
Contributor

chandlerprall commented Jun 18, 2020

Build error:

16:52:20 Token euiSelectableListItem.includedOptionInstructions has two differing defaults:
16:52:20 To deselect this option, press enter or space.
16:52:20 To exclude this option, press enter or space.

@chandlerprall
Copy link
Copy Markdown
Contributor

chandlerprall commented Jun 18, 2020

Universe does not like you today. Both CI steps failed with different network-related issues.

jenkins test this

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Jun 18, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3620/

chandlerprall
chandlerprall approved these changes Jun 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! Tested in the published docs

@myasonik myasonik merged commit a6ba2b5 into elastic:feature/selectable-a11y Jun 18, 2020
@myasonik myasonik deleted the selectable-a11y/exclusion branch June 18, 2020 19:29
@myasonik myasonik mentioned this pull request Jun 18, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chandlerprall chandlerprall chandlerprall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

accessibility

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@myasonik @chandlerprall @kibanamachine