More aria attributes for Selectable#3583
Merged
myasonik merged 4 commits intoelastic:feature/selectable-a11yfrom Jun 15, 2020
Merged
More aria attributes for Selectable#3583myasonik merged 4 commits intoelastic:feature/selectable-a11yfrom
myasonik merged 4 commits intoelastic:feature/selectable-a11yfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3583/ |
thompsongl
approved these changes
Jun 15, 2020
src/components/selectable/selectable_list/selectable_list.test.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Greg Thompson <thompson.glowe@gmail.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3583/ |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary (3 things)
aria-setsizeandaria-posinsetattributes to the options (gives accurate sizes and positions to screen readers in virtualized lists)aria-describedbyto the search fieldReviewer note: Each of these is a single commit if you want to review that way.
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] A changelog entry exists and is marked appropriately