Misc cleanup after resurecting#3570
Merged
myasonik merged 2 commits intoelastic:feature/selectable-a11yfrom Jun 9, 2020
Merged
Misc cleanup after resurecting#3570myasonik merged 2 commits intoelastic:feature/selectable-a11yfrom
myasonik merged 2 commits intoelastic:feature/selectable-a11yfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3570/ |
1 similar comment
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3570/ |
chandlerprall
suggested changes
Jun 9, 2020
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
One small ask, otherwise this looks good
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3570/ |
This was referenced Jun 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After about a month of neglect, I'm picking this work back up! In that time, a bug appeared (or, it always existed and we never caught it).
This fixes the bug (an extra tab stop in FF). While I was there, I also:
Note: This is targeting a feature branch (#3169)
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11- [ ] Props have proper autodocs- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] A changelog entry exists and is marked appropriately